Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): UI components typescript integration #162

Merged
merged 15 commits into from
Aug 2, 2024
Merged

chore(ui): UI components typescript integration #162

merged 15 commits into from
Aug 2, 2024

Conversation

barsukov
Copy link
Contributor

Summary

This is a first integration of typescript in a mixing approach that we have now supported javascript system.

Changes Made

  • Integrate typescript config to ui-components through rollup
  • integrate typescript config to storybook
  • Integrate ts lint for Typescript related files
  • Integrate vitest and typescript support in testing.

Related Issues

Testing Instructions

  1. npm i
  2. turbo test --filter=@cloudoperators/juno-ui-components
  3. turbo build --filter=@cloudoperators/juno-ui-components

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@barsukov barsukov added the enhancement New feature or request label Jul 31, 2024
@barsukov barsukov self-assigned this Jul 31, 2024
@barsukov barsukov requested review from franzheidl and a team as code owners July 31, 2024 12:07
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 834f681

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

edda
edda requested changes Jul 31, 2024
View reviewed changes
apps/example/tailwind.config.js Outdated Show resolved Hide resolved
packages/ui-components/src/components/AppShell/AppShell.test.tsx Outdated Show resolved Hide resolved
packages/ui-components/src/components/PageHeader/PageHeader.component.tsx Outdated Show resolved Hide resolved
packages/ui-components/src/svg/SapSvg.tsx Outdated Show resolved Hide resolved
@barsukov barsukov changed the title chore(ui) UI components typescript integration chore(ui): UI components typescript integration Aug 1, 2024
This was referenced Aug 2, 2024
Closed
Closed
Closed
@barsukov barsukov merged commit 03e8205 into main Aug 2, 2024
7 checks passed
@barsukov barsukov deleted the wowa-ui-components-typescript branch August 2, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edda edda edda approved these changes

@franzheidl franzheidl Awaiting requested review from franzheidl franzheidl is a code owner

Assignees

@barsukov barsukov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barsukov @edda